pvillard31 commented on code in PR #9930:
URL: https://github.com/apache/nifi/pull/9930#discussion_r2087200724
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl/StandardProcessGroupDAO.java:
##########
@@ -124,19 +126,30 @@ public boolean hasProcessGroup(String groupId) {
@Override
public void verifyUpdate(final ProcessGroupDTO processGroup) {
+ final ProcessGroup group = locateProcessGroup(flowController,
processGroup.getId());
+ verifyCanSetParameterContext(processGroup, group);
+
+ final String executionEngine = processGroup.getExecutionEngine();
+ if (executionEngine != null) {
+
group.verifyCanSetExecutionEngine(ExecutionEngine.valueOf(executionEngine));
+ }
+
+ final VersionControlInformationDTO versionControlInfoDTO =
processGroup.getVersionControlInformation();
+ final VersionControlInformation versionControlInformation =
group.getVersionControlInformation();
+ if (versionControlInfoDTO != null && versionControlInformation !=
null) {
+ throw new IllegalStateException("Cannot set Version Control Info
because process group is already under version control");
Review Comment:
Do we also want throw an exception if the process group has a child process
group with version control information? I know we currently allow nested
versioning but I feel like we may want to prevent it in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
