fgerlits commented on code in PR #1968:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1968#discussion_r2123384748
##########
minifi-api/include/minifi-cpp/core/RecordField.h:
##########
@@ -30,26 +30,8 @@ namespace org::apache::nifi::minifi::core {
struct RecordField;
-struct BoxedRecordField {
- BoxedRecordField() = default;
- BoxedRecordField(const BoxedRecordField&) = delete;
- BoxedRecordField(BoxedRecordField&& rhs) noexcept :
field(std::move(rhs.field)) {}
- BoxedRecordField& operator=(const BoxedRecordField&) = delete;
- BoxedRecordField& operator=(BoxedRecordField&& rhs) noexcept {
- field = std::move(rhs.field);
- return *this;
- };
- ~BoxedRecordField() = default;
-
- explicit BoxedRecordField(std::unique_ptr<RecordField>&& _field) :
field(std::move(_field)) {}
- bool operator==(const BoxedRecordField&) const;
- std::unique_ptr<RecordField> field = nullptr;
-};
-
-
using RecordArray = std::vector<RecordField>;
-
-using RecordObject = std::unordered_map<std::string, BoxedRecordField>;
+using RecordObject = std::unordered_map<std::string, RecordField>;
Review Comment:
Just out of curiosity, why is the boxing no longer necessary? (Or why was it
previously necessary?)
##########
thirdparty/couchbase/c++23_fixes.patch:
##########
Review Comment:
Can you put a comment somewhere about what this patch is about, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
