Copilot commented on code in PR #1972:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1972#discussion_r2132308252
##########
extensions/standard-processors/processors/TailFile.cpp:
##########
@@ -246,13 +246,18 @@ void TailFile::onSchedule(core::ProcessContext& context,
core::ProcessSessionFac
throw Exception(PROCESSOR_EXCEPTION, "Failed to get StateManager");
}
+ const auto result_format =
utils::parseEnumProperty<TailResultFormat>(context, ResultFormat);
if (auto delimiter_str = context.getProperty(Delimiter)) {
- if (auto parsed_delimiter = utils::string::parseCharacter(*delimiter_str))
{
- delimiter_ = *parsed_delimiter;
+ if (result_format == TailResultFormat::FlowFilePerBatch) {
Review Comment:
[nitpick] In `FlowFilePerBatch` mode, `delimiter_` remains set but is not
used. Consider explicitly clearing or documenting that it is ignored to avoid
stale state or confusion in future maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
