pvillard31 opened a new pull request, #9998:
URL: https://github.com/apache/nifi/pull/9998

   # Summary
   
   [NIFI-14626](https://issues.apache.org/jira/browse/NIFI-14626) - Fix MongoDB 
connection string creation
   
   When calling the constructor of ConnectionString, some authentication method 
absolutely require the username to be coming from the connection string 
regardless of the information provided via the Credentials that are set into 
the Client builder. This PR injects the username and password into the URI when 
creating the connection string to solve the problem.
   
   I've confirmed proper behavior before/after this PR against a MongoDB Atlas 
instance in GCP. This way, the user does not have to provide the 
username/password in the URI property of the controller service that would 
expose sensitive information.
   
   We may (I didn't investigate) be able to eliminate this approach if 
upgrading the client to a more recent major release but that would require 
additional work as they are breaking changes.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to