szaszm commented on code in PR #1981:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1981#discussion_r2157199227
##########
extensions/gcp/tests/CMakeLists.txt:
##########
@@ -20,6 +20,7 @@ file(GLOB GCS_TESTS "*.cpp")
FOREACH(testfile ${GCS_TESTS})
get_filename_component(testfilename "${testfile}" NAME_WE)
add_minifi_executable("${testfilename}" "${testfile}")
+ add_compile_definitions(_SILENCE_CXX20_REL_OPS_DEPRECATION_WARNING)
Review Comment:
This adds semi-global definitions. Please add them to the target instead
with target_compile_definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
