adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2161104314
##########
libminifi/include/Port.h:
##########
@@ -44,4 +48,15 @@ class Port final : public ForwardingNode {
PortType port_type_;
};
+class Port : public core::Processor {
Review Comment:
Port is handled as a processor in the system, since a lot of Processor
forwards the call to a ProcessorApi (which has its default methods in
ProcessorImpl), we either a) make Port not-a-processor, b) we virtualize all
forwarding calls in Processor just to override in Port to not to forward,
reimplementing some default behavior already in ProcessorImpl, the best course
of action is to keep the semantics port-is-a-processor and mirror the same
changes are for processor implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
