dan-s1 commented on PR #10058: URL: https://github.com/apache/nifi/pull/10058#issuecomment-3019684760
@zhtk I think overall this is a great idea. I had noticed SplitExcel was sluggish but until you I had not heard any complaints about it. What you have implemented is very similar to what POI has in `HSSFRow` with the method `copyRowFrom`. I had learnt about this when implementing [NIFI-14538](https://issues.apache.org/jira/browse/NIFI-14538). I have linked that ticket to your ticket. Hence I believe we should submit a ticket to POI for them to implement a similar method for XSSFSheet. I think you should give the justification you gave in the ticket that the current `copyRows` is a memory hog. Only in the event POI does not want to implement this method, I would then say go ahead with your code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
