fgerlits commented on code in PR #1985:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1985#discussion_r2175687691
##########
extensions/windows-event-log/ConsumeWindowsEventLog.h:
##########
@@ -117,6 +119,7 @@ class ConsumeWindowsEventLog : public core::ProcessorImpl {
.build();
EXTENSIONAPI static constexpr auto IdentifierMatcher =
core::PropertyDefinitionBuilder<>::createProperty("Identifier Match Regex")
.isRequired(false)
+ .withValidator(core::StandardPropertyValidators::NON_BLANK_VALIDATOR)
Review Comment:
A blank value for `Identifier Match Regex` doesn't really make sense: what
it does is disable Sid replacements, but the correct way to do that is to set
the `Apply Identifier Function` property to `false`.
However, I reverted this change in 4bcc689a55689ce36262d7b591dcb8fa53d8ecfe,
as it could break some flows, if someone has `Identifier Match Regex` set to a
blank value. I would say these flows are incorrect, but they used to work, so
they should probably continue to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
