[
https://issues.apache.org/jira/browse/NIFI-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987016#comment-17987016
]
Daniel Stieglitz edited comment on NIFI-14698 at 6/30/25 7:12 PM:
------------------------------------------------------------------
[~exceptionfactory] I thought this may be a straight replacement for example
replacing in OidcBearerTokenRefreshFilter the instantiation of
{code:java}
private final AntPathRequestMatcher currentUserRequestMatcher = new
AntPathRequestMatcher("/flow/current-user");{code}
with
{code:java}
private final PathPatternRequestMatcher currentUserRequestMatcher =
PathPatternRequestMatcher
.withDefaults()
.matcher("/flow/current-user");{code}
but five out of the six unit tests fail in OidcBearerTokenRefreshFilterTest. I
am not sure what changes need to be made perhaps elsewhere in the code. Is this
also perhaps part of the issue exhibited in NIFI-13302 where these changes at
this time cannot be made?
was (Author: JIRAUSER294662):
[~exceptionfactory] I thought this may be a straight replacement for example
replacing in OidcBearerTokenRefreshFilter the instantiation of
{code:java}
private final AntPathRequestMatcher currentUserRequestMatcher = new
AntPathRequestMatcher("/flow/current-user");{code}
with
{code:java}
private final PathPatternRequestMatcher currentUserRequestMatcher =
PathPatternRequestMatcher
.withDefaults()
.matcher("/flow/current-user");{code}
but five out of the six unit tests fail in OidcBearerTokenRefreshFilterTest. I
am not sure what changes need to be made perhaps elsewhere in the code. Is this
also perhaps part of the issue exhibited in NIFI-13302 ?
> Replace org.springframework.security.web.util.matcher.AntPathRequestMatcher
> with API suggested replacement
> ----------------------------------------------------------------------------------------------------------
>
> Key: NIFI-14698
> URL: https://issues.apache.org/jira/browse/NIFI-14698
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> Per the
> [https://docs.spring.io/spring-security/reference/api/java/org/springframework/security/web/util/matcher/AntPathRequestMatcher.html]
> javadocs, AntPathRequestMatcher has been deprecated and the suggested
> replacement is to use
> [PathPatternRequestMatcher|https://docs.spring.io/spring-security/reference/api/java/org/springframework/security/web/servlet/util/matcher/PathPatternRequestMatcher.html]
> The following places in the code base are where this is an issue
> {code:java}
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/client/web/OidcBearerTokenRefreshFilter.java:[75,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/client/web/OidcBearerTokenRefreshFilter.java:[75,72]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/logout/StandardLogoutFilter.java:[36,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/logout/StandardLogoutFilter.java:[41,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/logout/OidcLogoutFilter.java:[31,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[125,37]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[185,43]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[202,62]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2SingleLogoutFilter.java:[49,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2SingleLogoutFilter.java:[49,61]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2LocalLogoutFilter.java:[30,18]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/WebSecurityConfiguration.java:[83,42]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal
> [WARNING]
> nifi/nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/NiFiRegistrySecurityConfig.java:[61,59]
> [removal] AntPathRequestMatcher in
> org.springframework.security.web.util.matcher has been deprecated and marked
> for removal {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
