[ 
https://issues.apache.org/jira/browse/NIFI-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17993152#comment-17993152
 ] 

David Handermann commented on NIFI-14698:
-----------------------------------------

I tracked down the problem to several unit tests that were setting the servlet 
path instead of the request URI. Setting the request URI accurately reflects 
the path matching behavior in both cases, so I will submit a PR with the 
changes.

> Replace org.springframework.security.web.util.matcher.AntPathRequestMatcher 
> with API suggested replacement
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-14698
>                 URL: https://issues.apache.org/jira/browse/NIFI-14698
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: David Handermann
>            Priority: Minor
>
> Per the 
> [https://docs.spring.io/spring-security/reference/api/java/org/springframework/security/web/util/matcher/AntPathRequestMatcher.html]
>  javadocs, AntPathRequestMatcher has been deprecated and the suggested 
> replacement is to use 
> [PathPatternRequestMatcher|https://docs.spring.io/spring-security/reference/api/java/org/springframework/security/web/servlet/util/matcher/PathPatternRequestMatcher.html]
> The following places in the code base are where this is an issue
> {code:java}
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/client/web/OidcBearerTokenRefreshFilter.java:[75,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/client/web/OidcBearerTokenRefreshFilter.java:[75,72]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/logout/StandardLogoutFilter.java:[36,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/logout/StandardLogoutFilter.java:[41,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/logout/OidcLogoutFilter.java:[31,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[125,37]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[185,43]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/SamlAuthenticationSecurityConfiguration.java:[202,62]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2SingleLogoutFilter.java:[49,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2SingleLogoutFilter.java:[49,61]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/saml2/web/authentication/logout/Saml2LocalLogoutFilter.java:[30,18]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/configuration/WebSecurityConfiguration.java:[83,42]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal
> [WARNING] 
> nifi/nifi-registry/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/security/NiFiRegistrySecurityConfig.java:[61,59]
>  [removal] AntPathRequestMatcher in 
> org.springframework.security.web.util.matcher has been deprecated and marked 
> for removal {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to