exceptionfactory commented on code in PR #10062:
URL: https://github.com/apache/nifi/pull/10062#discussion_r2193452487
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-nar/src/main/resources/META-INF/NOTICE:
##########
@@ -103,6 +103,11 @@ The following binary components are provided under the
Apache Software License v
Amazon Ion Java
Copyright 2007-2019 Amazon.com, Inc. or its affiliates. All Rights
Reserved.
+ (ASLv2) AWS Glue Schema Registry Serializer Deserializer
+ The following NOTICE information applies:
+ AWS Glue Schema Registry Serializer Deserializer
+ Copyright 2020 Amazon.com, Inc. or its affiliates.
+
Review Comment:
A line should be added here to reference the NiFi package that contains the
copied classes.
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-schema-registry-service/src/main/java/org/apache/nifi/aws/schemaregistry/serde/GlueSchemaRegistryIncompatibleDataException.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2020 Amazon.com, Inc. or its affiliates.
+ * Licensed under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.aws.schemaregistry.serde;
+
+public class GlueSchemaRegistryIncompatibleDataException extends
RuntimeException {
+ public static final java.lang.String UNKNOWN_DATA_ERROR_MESSAGE = "Data is
not compatible with schema registry";
+ public static final java.lang.String
UNKNOWN_HEADER_VERSION_BYTE_ERROR_MESSAGE = "Invalid schema registry header
version byte in data";
+ public static final java.lang.String
UNKNOWN_COMPRESSION_BYTE_ERROR_MESSAGE = "Invalid schema registry compression
byte in data";
+
+ public GlueSchemaRegistryIncompatibleDataException(java.lang.String
message) {
Review Comment:
```suggestion
public GlueSchemaRegistryIncompatibleDataException(final String message)
{
```
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-schema-registry-service/src/main/java/org/apache/nifi/aws/schemaregistry/serde/README.md:
##########
@@ -0,0 +1,16 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+Files in this folder come from library:
software.amazon.schemaregistry:aws-schema-registry-serde:1.1.24
Review Comment:
This file can be removed and the reference to this package should be
mentioned in the `NOTICE` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
