Copilot commented on code in PR #1991:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1991#discussion_r2204728508
##########
docker/test/integration/features/consume_kafka.feature:
##########
@@ -304,7 +304,8 @@ Feature: Receiving data from using Kafka streaming platform
using ConsumeKafka
Then exactly these flowfiles are in the monitored directory's "processed"
subdirectory in less than 15 seconds: "<contents_after_tiberius>"
And exactly these flowfiles are in the monitored directory's "committed"
subdirectory in less than 15 seconds: "<contents_after_tiberius>"
- When a message with content "Caligula" is published to the
"ConsumeKafkaTest" topic
+ When "kafka-consumer-flow" flow is stopped
Review Comment:
You stop the Kafka consumer flow before publishing the `Caligula` message
but never restart it. To process the new message, add a step to start the
`kafka-consumer-flow` before asserting the processed output.
##########
docker/test/integration/cluster/containers/KafkaBrokerContainer.py:
##########
@@ -37,6 +38,8 @@ def __init__(self, feature_context, name, vols, network,
image_store, command=No
server_keystore.save(server_keystore_file.name, 'abcdefgh')
self.server_keystore_file_path = server_keystore_file.name
+ os.chmod(self.server_keystore_file_path, 0o644)
Review Comment:
[nitpick] The `os.chmod` call is repeated multiple times for different
temporary files; consider extracting a helper function to set permissions and
avoid duplication.
```suggestion
self.set_file_permissions(self.server_keystore_file_path, 0o644)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
