EndzeitBegins commented on code in PR #9868:
URL: https://github.com/apache/nifi/pull/9868#discussion_r2205448630


##########
nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileUserGroupProvider.java:
##########
@@ -670,6 +684,7 @@ private synchronized void load() throws JAXBException, 
IllegalStateException {
 
         if (emptyTenants) {
             populateInitialUsers(tenants);
+            populateInitialGroups(tenants);

Review Comment:
   I see where you're going with this, however I'm not sure if that's a good 
default.
   Say I want initial users `Alice`, `Bob`, and `Cleo` as well as initial 
groups `Users` and `Admins`. 
   I do not think it makes a lot of sense to add the users to both groups in 
this case. 
   
   In regards to the `Initial Admin Identity` (User)  and `Initial Admin Group` 
 however, one could argue that it would be a good idea to add the initial admin 
user to the initial admin group, in case both are defined. What do you think 
@mosermw?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to