lkuchars commented on PR #10094:
URL: https://github.com/apache/nifi/pull/10094#issuecomment-3077412459

   > Thanks for working on improved Protobuf support @lkuchars.
   > 
   > On a general evaluation, neither this pull request nor the Jira issue 
mention implementing Protobuf parsing using ANTLR, which raises a number of 
questions. As evident from the size of the ANTLR parser, this is a very complex 
effort. Can you provide some substantive background for pursuing this approach 
as opposed to using other Protobuf libraries?
   > 
   > In addition, this pull requests includes significant changes to the 
existing ProtobufReader, but it is not initially clear how that relates to the 
Confluent Schema Registry. With the potential level of complexity, it would be 
much better to look for ways to more carefully scope the set of changes.
   
   @exceptionfactory thank you for that initial look. I'll be adding more 
context in the JIRA today. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to