adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2213131546
##########
extensions/standard-processors/processors/RouteText.cpp:
##########
@@ -57,18 +54,10 @@ void RouteText::onSchedule(core::ProcessContext& context,
core::ProcessSessionFa
group_fallback_ = context.getProperty(GroupingFallbackValue).value_or("");
- {
- const auto static_relationships = RouteText::Relationships;
- std::vector<core::RelationshipDefinition>
relationships(static_relationships.begin(), static_relationships.end());
-
- for (const auto& property_name : getDynamicPropertyKeys()) {
- core::RelationshipDefinition rel{property_name, "Dynamic Route"};
- dynamic_relationships_[property_name] = rel;
- relationships.push_back(rel);
- logger_->log_info("RouteText registered dynamic route '{}'",
property_name);
- }
-
- setSupportedRelationships(relationships);
Review Comment:
calling `setSupportedRelationships` is actually useless (other than for
python processors) because neither `getSupportedRelationships` nor
`isSupportedRelationship` were used for verification purposes, although they
could be, but in `onSchedule` the verification has already completed, so there
is nobody to signal this new updates relationship set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
