GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/1471
NIFI-3432 Handle Multiple Result Sets in ExecuteSQL
This code change allows ExecuteSQL to handle queries that return multiple
result sets.
One existing unit test was failing and the results didn't make sense so I
adjusted it. Would be good to get a second pair of eyes on that.
I performed hand testing against MS SQL Server. In some tests I had to
enable `SET NOCOUNT ON`. Results were as expected.
I put some effort into building a unit test for Derby, but it's not
simple... Derby doesn't support submitting multi-statement requests in a single
SQL statement, and Stored Procedures are written in Java and require
registration. I tried putting one of these together but ran into issues and
decided to scrap it.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-3432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1471
----
commit 0a26a48c6a6fbf4d71f16003230d1eeda9a433d3
Author: patricker <[email protected]>
Date: 2017-02-02T19:19:48Z
NIFI-3432
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
