takraj commented on PR #10102:
URL: https://github.com/apache/nifi/pull/10102#issuecomment-3103617515

   @exceptionfactory 
   
   > although I would adjust the name and not include the word `executesql`
   
   Most of other attributes, except the fragment id/index/count include this 
word. Is there any reason to remove it?
   
   > However, if the Output Batch Size property is configured, then I would 
note in the description that this disables writing the FlowFile attribute.
   
   Uhm. It doesn't, and it shouldn't. Currently this attribute is always added 
to the last Flow File, regardless to the `Output Batch Size` and `Max Rows Per 
Flow File` settings. I can scope it down to only add, if *both* of these have a 
value, if you think it is reasonable.
   
   Currently the description of the attribute itself says:
   
   > This attribute is added to the very last created FlowFile, to indicate end 
of results. This is primarily serving the downstream processors, when 'Output 
Batch Size' is set, in which case no other information is available about the 
total number of fragments created from a single result set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to