mcgilman commented on PR #10115:
URL: https://github.com/apache/nifi/pull/10115#issuecomment-3104808902

   > I reviewed this from a UI perspective...
   > 
   > The concern that I have is that the "Reset All" button and dialog might be 
a bit ambiguous when the list of Counters has been filtered. The users might 
assume that only the Counters that match the filter criteria will be reset. 
Maybe the description in the confirmation dialog should indicate the total 
number of Counters getting reset?
   > 
   > I suppose another, more involved option would be to give the user the 
option to reset only the "filtered" Counters in addition to all. Not sure how 
beneficial that might be however. Might be enough to just make it more clear in 
the dialog that you are resetting `X` number of Counters.
   
   Thanks for reviewing @rfellows! I've pushed another commit that incorporates 
the total count into the reset prompt. Happy to tweak the language if you have 
further suggestions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to