exceptionfactory commented on code in PR #10097:
URL: https://github.com/apache/nifi/pull/10097#discussion_r2247977745
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.ts:
##########
@@ -124,12 +126,27 @@ export class ConnectionStatusTable extends
ComponentStatusTable<ConnectionStatus
return `${connection.connectionStatusSnapshot.percentUseCount}% |
${connection.connectionStatusSnapshot.percentUseBytes}%`;
}
+ formatLoadBalanceStatus(connection: ConnectionStatusSnapshotEntity):
string {
+ switch (connection.connectionStatusSnapshot.loadBalanceStatus) {
+ case 'LOAD_BALANCE_NOT_CONFIGURED':
+ return 'Not Configured';
+ case 'LOAD_BALANCE_ACTIVE':
+ return 'Active';
+ case 'LOAD_BALANCE_INACTIVE':
+ return 'Inactive';
+ default:
+ return 'unknown';
+
+ }
Review Comment:
Thanks for clarifying. The application uses uppercased values in other
places, but I agree that the title case rendering is more natural. On balance
then, I recommend returning the `loadBalanceStatus` value itself, instead of
`unknown`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
