sfc-gh-dhandermann commented on code in PR #10159:
URL: https://github.com/apache/nifi/pull/10159#discussion_r2248025418
##########
nifi-mock/src/main/java/org/apache/nifi/util/MockValidationContext.java:
##########
@@ -40,20 +40,30 @@
import java.util.Set;
import java.util.stream.Collectors;
-public class MockValidationContext extends MockControllerServiceLookup
implements ValidationContext, ControllerServiceLookup {
+public class MockValidationContext extends MockControllerServiceLookup
implements ValidationContext {
private final MockProcessContext context;
private final Map<String, Boolean> expressionLanguageSupported;
private final StateManager stateManager;
+ private final ParameterLookup parameterLookup;
private volatile boolean validateExpressions = true;
public MockValidationContext(final MockProcessContext processContext) {
- this(processContext, null);
+ this(processContext, (StateManager) null);
}
public MockValidationContext(final MockProcessContext processContext,
final StateManager stateManager) {
+ this(processContext, stateManager, ParameterLookup.EMPTY);
+ }
+
+ public MockValidationContext(final MockProcessContext processContext,
final Map<String, String> parameters) {
Review Comment:
Although the `Map<String, String>` of parameters is convenient, it is not
necessarily intuitive for all use cases, so I recommend removing this
constructor. Removing it also eliminates the need to disambiguate existing
usage of `null` for the `StateManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
