szaszm commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2258146606
##########
libminifi/include/core/FlowConfiguration.h:
##########
@@ -84,8 +84,7 @@ class FlowConfiguration : public CoreComponentImpl {
~FlowConfiguration() override;
// Create Processor (Node/Input/Output Port) based on the name
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const utils::Identifier &uuid);
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const std::string &fullname, const utils::Identifier &uuid);
+ std::unique_ptr<core::Processor> createProcessor(const std::string
&class_short, const std::string &fullclass, const std::string &name, const
utils::Identifier &uuid);
Review Comment:
I don't quite understand the question, but I'll try to clarify my point.
I've assumed that:
- class_short: short type name of the class, e.g. LogAttribute
- fullclass: long type name (including namespaces) of the class, e.g.
org::apache::nifi::minifi::processors::LogAttribute
- name: object name, i.e. if I create a LogAttribute in the flow with the
name "Log contents", then this will be "Log contents". I'd rename this. to
object_name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
