Copilot commented on code in PR #2006:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2006#discussion_r2273799653
##########
extensions/mqtt/processors/ConsumeMQTT.cpp:
##########
@@ -231,7 +231,7 @@ void ConsumeMQTT::checkProperties() {
logger_->log_warn("MQTT 5.0 specification does not support Clean Session.
Property is not used.");
}
- if (clientID_.empty()) {
+ if (client_id_.empty()) {
Review Comment:
This condition will never be true because the AbstractMQTTProcessor now
automatically generates a UUID when the client ID is not set, so client_id_
will never be empty. This validation logic should be updated or removed since
the automatic generation in the parent class ensures client_id_ is always
populated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
