Copilot commented on code in PR #1996: URL: https://github.com/apache/nifi-minifi-cpp/pull/1996#discussion_r2276388343
########## extensions/standard-processors/processors/ConvertRecord.h: ########## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <string_view> +#include <utility> + +#include "core/AbstractProcessor.h" +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "core/PropertyDefinitionBuilder.h" +#include "core/RelationshipDefinition.h" +#include "controllers/RecordSetReader.h" +#include "controllers/RecordSetWriter.h" + +namespace org::apache::nifi::minifi::processors { + +class ConvertRecord : public core::AbstractProcessor<ConvertRecord> { + public: + using core::AbstractProcessor<ConvertRecord>::AbstractProcessor; + + EXTENSIONAPI static constexpr const char* Description = "Converts records from one data format to another using configured Record Reader and Record Write Controller Services."; Review Comment: The description contains "Record Write Controller Services" which should be "Record Writer Controller Services" for consistency with the property name. ```suggestion EXTENSIONAPI static constexpr const char* Description = "Converts records from one data format to another using configured Record Reader and Record Writer Controller Services."; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
