exceptionfactory commented on PR #10186:
URL: https://github.com/apache/nifi/pull/10186#issuecomment-3188315349

   > Just to make sure we're on the same page:
   > 
   >     * have the option to limit the number of commits retrieved and expose 
this as a property
   > 
   >     * have an in-memory cache of the commits base on the commit hash with 
a hard coded value
   > 
   > 
   > And remove the okhttp client cache that is file based.
   > 
   > Right?
   
   Slight adjustment to the first bullet, I recommend a hard limit on the 
number of commits retrieved, as I don't think it needs to be a configurable 
property.
   
   Yes, on the in-memory cache with hard-coded limit, and yes on the removing 
the OkHttp client cache.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to