szaszm commented on code in PR #1968:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1968#discussion_r2286322495
##########
CMakeLists.txt:
##########
@@ -315,9 +315,11 @@ else()
list(APPEND MINIFI_CPP_COMPILE_OPTIONS -Wall -Wextra)
if(MINIFI_FAIL_ON_WARNINGS)
list(APPEND MINIFI_CPP_COMPILE_OPTIONS -Werror)
- # -Wrestrict may cause build failure in GCC 12
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104336
- if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
- list(APPEND MINIFI_CPP_COMPILE_OPTIONS -Wno-error=restrict)
Review Comment:
GCC 12 is still supported right? In that case we should probably keep this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
