[
https://issues.apache.org/jira/browse/NIFI-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854530#comment-15854530
]
ASF GitHub Bot commented on NIFI-3408:
--------------------------------------
Github user gglanzani commented on the issue:
https://github.com/apache/nifi/pull/1467
Hi @pvillard31 thanks for the review. I've incorporated the changes.
I've renamed the two new attributes to
`invoke.http.java.exception.{class,message}`. They reflect better the
underlying methods.
Note: I've not updated the test to test for the message. I think it would
turn out to be a pretty verbose test BUT let me know in case you disagree :)
> Add an attribute for failure reason to InvokeHTTP in all cases to match docs
> ----------------------------------------------------------------------------
>
> Key: NIFI-3408
> URL: https://issues.apache.org/jira/browse/NIFI-3408
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Priority: Minor
>
> Originally brought up on the mailing list[1], the InvokeHTTP docs state:
> ```
> The original FlowFile will be routed on any type of connection failure,
> timeout or general exception. It will have new attributes detailing the
> request.
> ```
> Adding attributes currently only happens though when a response is received
> from the server, so not attributes if it fails to connect or the socket times
> out.
> These attributes should be added.
> [1]
> http://apache-nifi-users-list.2361937.n4.nabble.com/InvokeHTTP-and-SocketTimeoutException-td743.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
