[
https://issues.apache.org/jira/browse/NIFI-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016023#comment-18016023
]
ASF subversion and git services commented on NIFI-14173:
--------------------------------------------------------
Commit 65572e8a1a1061ba9d3fb0290e0789fec8c187fe in nifi's branch
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=65572e8a1a ]
[NIFI-14173] Codemirror V6 (#10144)
* [NIFI-14173] Codemirror V6
* update shared lib import paths
* regenerate package-lock
* refactor codemirror component
* address review feedback, refactor codemirror component, update codemirror
instances configs
* remove parameter and EL highlight wdiget from example data and add it to
output data for jolt
* remove README
* address review feedback
* add 700 wieght fonts, remove the rest of codemirror search, remove foldgutter
from ua-editor
* refactor codemirror nf language package, fix issue with autocomplete for EL
and paramters inside "", esc key closes autocomplete tooltip
* refactor language package to improve EL function and parameter highlightiing,
match preivous use cases, and increase code coverage
* () should not be styled as an el func name or parameter name, add more unit
tests
* improve codemirrir-nifi-language-package unit test
* position cursor after autocomplete
* remove close bracket extension, restore stream parser, remove EL/Param
highlight functions
* remove commented out code
* revert to use currentState
* lexer grammer
* theme nfel syntax
* dial in individual editor configurations and syntax highlighting
* ignore generated nfel grammer and README from rat check
* a few more updates
* update el and parameter syntax highlight colors
* some cleanup
* update EL and Parameter tooltip styles
* updates to dynamic highlighting
* update packages
* quoted parameters, parameters with spaces, and embedded parameters now
properly styled
* EL functions style updates
* clean up and finalize grammar to codemirror tag, codemirror tag to css token
mappings
* clean up some tests, prettier, prevent autocomplete on escaped parameter
* add missing token
* fix cursor color
* map el function to --editor-function
* remove console.log from test
* add test coverage, simplify, cleanup, and improve grammar and mappings
* update deps
* make isInitialized private
* quick fix
* properly identify EL function or attribute
* restore bracket matching
* cleanup lint issue
* cleanup el-service.spec
* regenerate package-lock
> Upgrade to Codemirror 6
> -----------------------
>
> Key: NIFI-14173
> URL: https://issues.apache.org/jira/browse/NIFI-14173
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Core UI
> Reporter: Matt Gilman
> Assignee: Scott Aslan
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Codemirror is currently leveraged throughout the different NiFi UIs.
> * Editing Properties - supports a custom language mode for EL and Parameter
> references
> * Content Viewers
> * Jolt Advanced UI
> * etc
> These all leverage Codemirror 5 which was distributed as UMD modules and
> requires addon's (like language modes, etc) to be loaded in `main.ts`. This
> is been problematic for when reusing shared components and styles and when
> they are transitively referenced in unit tests. The migration to Codemirror
> 6 is detailed here [1]. A possible Angular wrapper here [2].
> [1] https://codemirror.net/docs/migration/
> [2] https://github.com/acrodata/code-editor
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
