lordgamez commented on code in PR #1966: URL: https://github.com/apache/nifi-minifi-cpp/pull/1966#discussion_r2300750906
########## libminifi/test/libtest/integration/HTTPHandlers.cpp: ########## @@ -280,7 +301,7 @@ void HeartbeatHandler::verifyJsonHasAgentManifest(const rapidjson::Document& roo REQUIRE(manifestHash.length() == 128); // throws if not a valid hexadecimal hash - const auto hashVec = utils::string::from_hex(manifestHash); + const auto hashVec = minifi::utils::string::from_hex(manifestHash); Review Comment: I think there were some namespace changes and in the `minifi::test` namespace where this file we also have `test::utils`, so is if we use `utils` namespace the compiler looks for the function in the `minifi::test::utils` where it does not find this function, so we have to use `minifi::utils` here specifically to avoid the compilation error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
