awelless commented on PR #10245:
URL: https://github.com/apache/nifi/pull/10245#issuecomment-3228070134

   @exceptionfactory 
   For some reason I thought that `nifi-mock` is an internal module and not a 
part of external API.
   Sure, constructors should not be changed. I reverted that.
   
   I still believe that builder introduces readability, compared a constructor 
with 7 parameters. What's your opinion on that?
   Shall we promote the builder usage by, e.g. deprecating the constructors 
with a large number of arguments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to