martinzink commented on code in PR #1993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1993#discussion_r2306893058
##########
minifi_main/CMakeLists.txt:
##########
@@ -81,10 +81,18 @@ if (NOT WIN32)
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND NOT APPLE)
target_link_options(minifiexe PRIVATE "-Wl,--disable-new-dtags")
endif()
- if (APPLE)
- set_target_properties(minifiexe PROPERTIES INSTALL_RPATH
"@loader_path")
+
+ if (MINIFI_PACKAGING_TYPE STREQUAL "RPM")
+ set_target_properties(minifiexe PROPERTIES
+ INSTALL_RPATH "/usr/${CMAKE_INSTALL_LIBDIR}/${PROJECT_NAME}")
Review Comment:
thats true 👍 , but we would need more changes and testing so even if we were
to change to configure-time specific prefix I wouldnt trust it yet, I think we
can change these in a followup PR with proper testing but I wouldnt burdon this
PR with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
