scottyaslan commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2308646676
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/expolorer/feature/explorer.component.html: ########## @@ -0,0 +1,54 @@ +<!-- +~ Licensed to the Apache Software Foundation (ASF) under one or more +~ contributor license agreements. See the NOTICE file distributed with +~ this work for additional information regarding copyright ownership. +~ The ASF licenses this file to You under the Apache License, Version 2.0 +~ (the "License"); you may not use this file except in compliance with +~ the License. You may obtain a copy of the License at +~ +~ http://www.apache.org/licenses/LICENSE-2.0 +~ +~ Unless required by applicable law or agreed to in writing, software +~ distributed under the License is distributed on an "AS IS" BASIS, +~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +~ See the License for the specific language governing permissions and +~ limitations under the License. +--> + +<div class="pb-5 px-5 flex flex-col h-full"> + <div class="h-full flex flex-col"> + <h3 class="primary-color">Flows</h3> + <div class="flex justify-between items-baseline"> Review Comment: The context-error-banners can be used for listings as well as dialogs. Each banner should have a unique context key. Previously we just presented the error in a dialog like: <img width="1655" height="1088" alt="Screenshot 2025-08-28 at 5 52 14 PM" src="https://github.com/user-attachments/assets/9bbb314c-9c8c-4dce-b7cc-be1aa3b31d8e"; /> For this effort I would expect the error banner to be displayed above the filters. This can also be a follow on effort if you like. Please just create a jira for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
