mosermw commented on code in PR #9967:
URL: https://github.com/apache/nifi/pull/9967#discussion_r2337779526
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -2802,6 +2819,24 @@ public Set<ComponentDifferenceDTO>
createComponentDifferenceDtosForLocalModifica
return differencesByComponent.keySet();
}
+ private static final Pattern DIFFERENCE_DESCRIPTION_PATTERN =
Pattern.compile(".*artifact='(.*)'.*version='(.*)'].*version='(.*)']'$");
Review Comment:
I moved this code to the ConciseEvolvingDifferenceDescriptor class where
some other difference descriptions are generated, and I do think this made the
code cleaner.
Should I rebase this PR onto main, to try to resolve the macos build/test
issues in the CI checks? Or can those checks be ignored for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
