rfellows commented on code in PR #10287:
URL: https://github.com/apache/nifi/pull/10287#discussion_r2340910724
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/component-state/component-state.component.html:
##########
@@ -89,6 +106,23 @@ <h2 mat-dialog-title>Component State</h2>
</ng-container>
}
+ <!-- Actions Column -->
+ @if (displayedColumns.includes('actions')) {
+ <ng-container matColumnDef="actions">
+ <th mat-header-cell *matHeaderCellDef></th>
+ <td mat-cell *matCellDef="let item">
+ <button
+ [disabled]="isClearing"
+ mat-icon-button
+ color="primary"
+
(click)="clearComponentStateEntry(item)"
+ [title]="'Clear state entry: ' +
item.key">
+ <i class="fa fa-trash"
aria-hidden="true"></i>
Review Comment:
from MDN:
> `aria-hidden="true"` should not be used on elements that can receive focus
These trash can icons can be tabbed to, so we should not be setting this
attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
