szaszm commented on code in PR #2016:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2016#discussion_r2352012434
##########
extensions/azure/controllerservices/AzureStorageCredentialsService.cpp:
##########
@@ -39,13 +43,13 @@ void AzureStorageCredentialsService::onEnable() {
credentials_.setSasToken(*sas_token);
}
if (auto common_storage_account_endpoint_suffix =
getProperty(CommonStorageAccountEndpointSuffix.name)) {
- credentials_.setEndpontSuffix(*common_storage_account_endpoint_suffix);
+ credentials_.setEndpointSuffix(*common_storage_account_endpoint_suffix);
}
if (auto connection_String = getProperty(ConnectionString.name)) {
credentials_.setConnectionString(*connection_String);
}
- if (auto use_managed_identity_credentials =
getProperty(UseManagedIdentityCredentials.name) |
utils::andThen(parsing::parseBool)) {
-
credentials_.setUseManagedIdentityCredentials(*use_managed_identity_credentials);
+ if (auto managed_identity_client_id =
getProperty(ManagedIdentityClientId.name)) {
+ credentials_.setManagedIdentityClientId(*managed_identity_client_id);
Review Comment:
Could you highlight this in the PR description? Hopefully it makes it into
the merge commit message.
##########
extensions/azure/controllerservices/AzureStorageCredentialsService.cpp:
##########
@@ -39,13 +43,13 @@ void AzureStorageCredentialsService::onEnable() {
credentials_.setSasToken(*sas_token);
}
if (auto common_storage_account_endpoint_suffix =
getProperty(CommonStorageAccountEndpointSuffix.name)) {
- credentials_.setEndpontSuffix(*common_storage_account_endpoint_suffix);
+ credentials_.setEndpointSuffix(*common_storage_account_endpoint_suffix);
}
if (auto connection_String = getProperty(ConnectionString.name)) {
credentials_.setConnectionString(*connection_String);
}
- if (auto use_managed_identity_credentials =
getProperty(UseManagedIdentityCredentials.name) |
utils::andThen(parsing::parseBool)) {
-
credentials_.setUseManagedIdentityCredentials(*use_managed_identity_credentials);
+ if (auto managed_identity_client_id =
getProperty(ManagedIdentityClientId.name)) {
+ credentials_.setManagedIdentityClientId(*managed_identity_client_id);
Review Comment:
Could you highlight the breaking change in the PR description? Hopefully it
makes it into the merge commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
