sardell commented on code in PR #9855: URL: https://github.com/apache/nifi/pull/9855#discussion_r2337675841
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/error-helper.service.ts: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { Injectable } from '@angular/core'; +import { HttpErrorResponse } from '@angular/common/http'; +import * as ErrorActions from '../state/error/error.actions'; +import { Action } from '@ngrx/store'; + +@Injectable({ providedIn: 'root' }) +export class ErrorHelper { Review Comment: Sorry about that, @scottyaslan . 😄 While I did move this error service and the state-related into the shared folder, I ran into an issue: The error actions code leverages an interface (ErrorContextKey) that is application-specific. The approach I propose we can take is to move all ErrorContextKey enums into the shared folder, rename them to be application-specific and use a union type that will look something like: ``` export interface ErrorContext { context: NiFiRegistryErrorContextKey | NiFiErrorContextKey; errors: string[]; } ``` The downside to this approach is you could accidentally use a context from one application in another and the compiler won't catch the mistake. I view the risk as low but I'm open to better suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
