rfellows commented on code in PR #10350:
URL: https://github.com/apache/nifi/pull/10350#discussion_r2394680803
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/resources/feature/resources.component.html:
##########
@@ -15,8 +15,11 @@
~ limitations under the License.
-->
-<div class="pb-5 px-5 flex flex-col h-full">
- <div class="h-full flex flex-col">
+<div class="flex flex-col h-screen justify-between">
+ <header class="mb-5 nifi-registry-header">
+ <app-header></app-header>
Review Comment:
This seems to be causing an issue in the test. its not failing, but printing
a console error. maybe we can get that cleaned up?
```
apps/nifi-registry/src/app/pages/resources/feature/resources.component.spec.ts
● Console
console.error
NG0304: 'app-header' is not a known element (used in the
'ResourcesComponent' component template):
1. If 'app-header' is an Angular component, then verify that it is a
part of an @NgModule where this component is declared.
2. If 'app-header' is a Web Component then add
'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to
suppress this message.
at validateElementIsKnown
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:5990:25)
at ɵɵelementStart
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:23207:9)
at ɵɵelement
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:23250:5)
at ResourcesComponent_Template (../../ng:/ResourcesComponent.js:52:9)
at executeTemplate
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:7939:9)
at renderView
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:8561:13)
at renderComponent
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:8506:5)
at renderChildComponents
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:8609:9)
at renderView
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:8589:13)
at ComponentFactory2.create
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:13500:17)
at initComponent
(../../node_modules/@angular/core/fesm2022/testing.mjs:2068:51)
at _ZoneDelegate.invoke
(../../node_modules/zone.js/bundles/zone.umd.js:416:32)
at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke
(../../node_modules/zone.js/bundles/zone-testing.umd.js:2177:43)
at _ZoneDelegate.invoke
(../../node_modules/zone.js/bundles/zone.umd.js:415:38)
at Object.onInvoke
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:16691:33)
at _ZoneDelegate.invoke
(../../node_modules/zone.js/bundles/zone.umd.js:415:38)
at ZoneImpl.run (../../node_modules/zone.js/bundles/zone.umd.js:147:47)
at NgZone.run
(../../node_modules/@angular/core/fesm2022/debug_node.mjs:16537:28)
at _TestBedImpl.createComponent
(../../node_modules/@angular/core/fesm2022/testing.mjs:2073:41)
at Function.createComponent
(../../node_modules/@angular/core/fesm2022/testing.mjs:1854:37)
at src/app/pages/resources/feature/resources.component.spec.ts:62:27
at _ZoneDelegate.invoke
(../../node_modules/zone.js/bundles/zone.umd.js:416:32)
at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke
(../../node_modules/zone.js/bundles/zone-testing.umd.js:2177:43)
at _ZoneDelegate.invoke
(../../node_modules/zone.js/bundles/zone.umd.js:415:38)
at ZoneImpl.run (../../node_modules/zone.js/bundles/zone.umd.js:147:47)
at Object.wrappedFunc
(../../node_modules/zone.js/bundles/zone-testing.umd.js:450:38)
```
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/app-routing.module.ts:
##########
@@ -48,7 +49,10 @@ const routes: Routes = [
]
}
Review Comment:
missing a comma here.
```
> nx run nifi-registry:build:production
Application bundle generation failed. [4.220 seconds] -
2025-10-01T13:55:56.991Z
✘ [ERROR] TS1005: ',' expected. [plugin angular-compiler]
apps/nifi-registry/src/app/app-routing.module.ts:52:4:
52 │ {
╵ ^
```
```suggestion
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
