dan-s1 commented on code in PR #10351:
URL: https://github.com/apache/nifi/pull/10351#discussion_r2394825304
##########
nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/test/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchJsonTest.java:
##########
@@ -156,7 +156,7 @@ void testMigrateProperties() {
assertTrue(runner.getProcessContext().getProperties().keySet().stream().noneMatch(pd
-> "put-es-json-not_found-is-error".equals(pd.getName())));
assertTrue(runner.getProcessContext().getProperties().keySet().stream().noneMatch(pd
-> "put-es-json-error-documents".equals(pd.getName())));
- assertEquals(1, result.getPropertiesRenamed().size());
+ assertTrue(1 < result.getPropertiesRenamed().size());
Review Comment:
Yes, if it is not changed the unit test fails since there are many more
properties renamed because of the call to `super.migrateProperties(config);`.
I was trying to move forward to ensure the test passed so I made this specific
change. I can rewrite this if you would like to assert which properties were
renamed in the `PutElasticsearchJson`. Please let me know what you would like
me to do. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
