szaszm commented on code in PR #2029: URL: https://github.com/apache/nifi-minifi-cpp/pull/2029#discussion_r2439267095
########## .clang-tidy: ########## @@ -1,6 +1,7 @@ Checks: > -clang-analyzer-optin.cplusplus.VirtualCall, -clang-analyzer-optin.core.EnumCastOutOfRange, + -clang-analyzer-unix.BlockInCriticalSection, Review Comment: I've checked this: it warns for the read in FileMutex, and asio internals whenever networking is used. None of the warnings seemed useful: FileMutex is inherently meant to interact with files atomically (achieved with the mutex), and asio internal mutexes are not our responsibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
