lordgamez commented on code in PR #2040:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2040#discussion_r2401893044
##########
libminifi/include/core/state/UpdatePolicy.h:
##########
@@ -94,7 +89,7 @@ class UpdatePolicy {
class UpdatePolicyBuilder {
public:
static std::unique_ptr<UpdatePolicyBuilder> newBuilder(bool enable_all =
false) {
- std::unique_ptr<UpdatePolicyBuilder> policy =
std::unique_ptr<UpdatePolicyBuilder>( new UpdatePolicyBuilder(enable_all));
+ std::unique_ptr<UpdatePolicyBuilder> policy =
std::unique_ptr<UpdatePolicyBuilder>( new UpdatePolicyBuilder(enable_all)); //
NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
Review Comment:
The UpdatePolicyBuilder's constructor is protected and make_unique cannot
access it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
