rfellows commented on code in PR #10393:
URL: https://github.com/apache/nifi/pull/10393#discussion_r2410859302
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/settings/ui/registry-clients/edit-registry-client/edit-registry-client.component.ts:
##########
@@ -142,9 +151,28 @@ export class EditRegistryClient extends TabbedDialog {
});
}
+ private getModifiedProperties(): ModifiedProperties {
+ const propertyControl: AbstractControl | null =
this.editRegistryClientForm.get('properties');
+ if (propertyControl) {
Review Comment:
There is a bug in this implementation. If you open a saved github registry
client and attempt to Verify it without making any changes, it will fail every
time. Once you make a change to one of the properties and try to verify again,
it will pass (assuming the configuration is actually good)
The problem is that if the form is not `dirty`, you are passing essentially
the whole configuration back. Since the sensitive value isn't known to the UI
at this point, 5 asterisks (`*****`) is passed down as the value of the
sensitive property and it is failing.
The API only expects changed properties to be included in the payload. You
get away with it when initially configuring the client since the user is
actually providing the sensitive value at that point.
```suggestion
if (propertyControl && propertyControl.dirty) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
