pvillard31 opened a new pull request, #10341:
URL: https://github.com/apache/nifi/pull/10341
# Summary
NIFI-15011 - FlowDifferenceFilters - handle splitRelationship()
Consider something like:
````java
@Override
public void migrateRelationships(final RelationshipConfiguration
config) {
if (!config.hasRelationship(B)) {
config.splitRelationship(A.getName(), A.getName(), B.getName());
}
super.migrateRelationships(config);
}
````
Then I'd see a local change such as:
Selected Relationships Changed - From '[A]' to '[A, B]'
If the relation B didn't exist at all in the flow definition, and if the
source processor does not support dynamic relationships, then this change
should not show as a local change.
Similarly, if the processor does not support dynamic relationships and if we
have:
````java
@Override
public void migrateRelationships(final RelationshipConfiguration
config) {
if (!config.hasRelationship(A)) {
config.splitRelationship(OLD.getName(), A.getName(), B.getName());
}
super.migrateRelationships(config);
}
````
(we remove an OLD relationship that we split into two new ones)
We should not show a local change like:
Selected Relationships Changed - From '[OLD]' to '[A, B]'
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
