greyp9 commented on code in PR #10366:
URL: https://github.com/apache/nifi/pull/10366#discussion_r2407789517
##########
nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/WriteAvroResultWithSchema.java:
##########
@@ -58,7 +58,11 @@ public void flush() throws IOException {
@Override
public Map<String, String> writeRecord(final Record record) throws
IOException {
final GenericRecord rec = AvroTypeUtil.createAvroRecord(record,
schema);
- dataFileWriter.append(rec);
+ try {
+ dataFileWriter.append(rec);
+ } catch (final DataFileWriter.AppendWriteException e) {
+ throw new IOException(e);
Review Comment:
Thanks @jrsteinebrey @pvillard31 @exceptionfactory for your input!
I propose making this update to the changeset:
> Another variation would be for AvroWriter to throw
MalformedRecordException instead of IOException, as that better conveys the
particular problem (bad data).
Does that work for everyone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
