ravinarayansingh commented on PR #10355: URL: https://github.com/apache/nifi/pull/10355#issuecomment-3354010711
> Thanks for proposing this improvement @ravinarayansingh. > > On initial review, I'm concerned about introducing a custom `InputStream` implementation for this particular use case. > > The `RestLookupService` is not designed for handling very large responses in general, although accommodating something larger seems reasonable. Instead of adding a custom `InputStream` with associated temporary file management, what do you think about simply using a larger buffer size for the `BufferedInputStream`? I agree that introducing a property is probably unnecessary, but increasing the buffer size to something like 1 MB or 8 MB seems like it would provide a reasonable size to cover more use cases, without introducing more complexity. Hi @exceptionfactory Agreed, an 8 MB buffer size sounds like the right balance. I’ll go ahead and make the change accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
