rfellows commented on code in PR #10348:
URL: https://github.com/apache/nifi/pull/10348#discussion_r2388436285
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/ui/header/header.component.html:
##########
@@ -39,12 +39,16 @@
<i class="fa fa-navicon text-[32px]"></i>
</button>
<mat-menu #globalMenu="matMenu" xPosition="before">
- <button mat-menu-item
class="global-menu-item">Buckets</button>
- <button mat-menu-item
class="global-menu-item">Users/Groups</button>
+ <button mat-menu-item class="global-menu-item"><i
class="fa mr-2"></i>Buckets</button>
+ <button mat-menu-item class="global-menu-item"><i
class="fa mr-2"></i>Users/Groups</button>
<button mat-menu-item class="global-menu-item">
<i class="fa fa-info-circle primary-color mr-2"></i>
About
</button>
+ <a mat-menu-item class="global-menu-item"
[href]="documentationUrl" target="_blank">
Review Comment:
One minor suggestion would be to add `noopener noreferrer`. This would
prevent the new tab from having access to the window.opener property, which is
a security best practice when opening external links in a new tab. The noopener
prevents access to the parent window, and noreferrer prevents the referrer
header from being sent to the target site.
```suggestion
<a mat-menu-item class="global-menu-item"
[href]="documentationUrl" target="_blank" rel="noopener noreferrer">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
