adamdebreceni commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2425718662
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
-struct does_compile : std::false_type {};
+struct compiles_as_a_constant_expression : std::false_type {};
template<int N, int D>
-struct does_compile<N, D,
+struct compiles_as_a_constant_expression<N, D,
// we must force evaluation so decltype won't do
- typename std::enable_if<(utils::intdiv_ceil(N, D), true)>::type> :
std::true_type {};
+ std::enable_if_t<(minifi::utils::intdiv_ceil(N, D), true)>> :
std::true_type {};
-static_assert(does_compile<2, 3>::value, "does_compile should work");
-static_assert(!does_compile<1, 0>::value, "constexpr division by zero
shouldn't compile");
+static_assert(compiles_as_a_constant_expression<2, 3>::value,
"compiles_as_a_constant_expression should work");
+static_assert(!compiles_as_a_constant_expression<1, 0>::value, "constexpr
division by zero shouldn't compile");
-TEST_CASE("GeneralUtils::dereference", "[dereference]") {
+TEST_CASE("Generalminifi::utils::dereference", "[dereference]") {
const int a = 42;
const auto pa = gsl::make_not_null(&a);
- REQUIRE(42 == utils::dereference(pa));
- REQUIRE(&a == &utils::dereference(pa));
+ REQUIRE(42 == minifi::utils::dereference(pa));
+ REQUIRE(&a == &minifi::utils::dereference(pa));
const auto uniq_a = gsl::make_not_null(std::make_unique<int>(99));
- REQUIRE(99 == utils::dereference(uniq_a));
+ REQUIRE(99 == minifi::utils::dereference(uniq_a));
}
-TEST_CASE("GeneralUtils::unsafe_dereference", "[unsafe_dereference]") {
+TEST_CASE("Generalminifi::utils::unsafe_dereference", "[unsafe_dereference]") {
Review Comment:
these test names got accidentally got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
