szaszm commented on code in PR #2050:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2050#discussion_r2442388528
##########
extensions/python/pythonprocessors/nifiapi/properties.py:
##########
@@ -262,12 +261,17 @@ def asDataSize(self, data_unit: DataUnit) -> float:
return 0
def evaluateAttributeExpressions(self, flow_file: FlowFile = None):
- if flow_file is None or not self.el_supported:
Review Comment:
`flow_file` is no longer checked for `None`, but it's still used below as if
it were set. Is this intentional?
##########
extensions/python/types/PyProcessContext.cpp:
##########
@@ -30,7 +30,9 @@ namespace org::apache::nifi::minifi::extensions::python {
static PyMethodDef PyProcessContext_methods[] = { //
NOLINT(cppcoreguidelines-avoid-c-arrays)
{"getProperty", (PyCFunction) PyProcessContext::getProperty, METH_VARARGS,
nullptr},
+ {"getRawProperty", (PyCFunction) PyProcessContext::getRawProperty,
METH_VARARGS, nullptr},
Review Comment:
idea: if a function is not meant to be part of the public API, then we
should prefix it with an underscore, following Python conventions. The two new
functions look like they're not meant to be public, but I can't tell for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
