szaszm commented on code in PR #2047:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2047#discussion_r2442418171
##########
libminifi/CMakeLists.txt:
##########
@@ -68,7 +62,12 @@ endif()
file(GLOB PROCESSOR_SOURCES "src/processors/*.cpp" )
-add_minifi_library(core-minifi SHARED ${SOURCES})
+add_minifi_library(core-minifi SHARED ${SOURCES} ${BISON_el-parser_OUTPUTS}
${FLEX_el-scanner_OUTPUTS})
+target_include_directories(core-minifi SYSTEM PRIVATE
${EL_GENERATED_INCLUDE_DIR})
Review Comment:
We add the generated include dir but not the generated sources? What happens
with those? Or are those the same as `${BISON_el-parser_OUTPUTS}` and
`${FLEX_el-scanner_OUTPUTS}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
