martinzink commented on code in PR #2004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2004#discussion_r2444135417
##########
extensions/mqtt/processors/AbstractMQTTProcessor.h:
##########
@@ -256,13 +258,16 @@ class AbstractMQTTProcessor : public core::ProcessorImpl {
std::optional<std::chrono::seconds> maximum_session_expiry_interval_;
std::optional<std::chrono::seconds> server_keep_alive_;
+ std::shared_ptr<core::RecordSetReader> record_set_reader_;
+ std::shared_ptr<core::RecordSetWriter> record_set_writer_;
Review Comment:
Probably nitpicking but since these only make sense if both or neither are
set, maybe we could refactor this into a struct with 2 not null shared ptrs and
have an optional member here that could contain that struct.
And since this might be not an unusual request this struct might even be
put into libminifi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
