[
https://issues.apache.org/jira/browse/NIFI-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860018#comment-15860018
]
ASF GitHub Bot commented on NIFI-3403:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/1494
NIFI-3403 - Fix NPE in InvokeHTTP
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-3403
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1494
----
commit 37496d336c47f8c9a542f02e47314ace07b43528
Author: Pierre Villard <[email protected]>
Date: 2017-02-09T19:10:33Z
NIFI-3403 - Fix NPE in InvokeHTTP
----
> NPE in InvokeHTTP
> -----------------
>
> Key: NIFI-3403
> URL: https://issues.apache.org/jira/browse/NIFI-3403
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 0.7.1, 1.1.1
> Reporter: Brandon DeVries
> Priority: Minor
>
> InvokeHTTP throws an NPE when running in "source" mode if given a value for
> "Attributes to Send". If this value is set, it attempts to do\[1\]...
> {code}
> requestFlowFile.getAttributes(){code}
> ...without checking if requestFlowFile == null (which will be the case when
> running in "source" mode).
> \[1\]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L859
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
