martinzink commented on code in PR #2056: URL: https://github.com/apache/nifi-minifi-cpp/pull/2056#discussion_r2482115307
########## extensions/python/tests/PythonManifestTests.cpp: ########## @@ -170,7 +170,7 @@ class MyPyProc5(FlowFileTransform): controller.configuration_->set(minifi::Configuration::nifi_extension_path, "*minifi-python-script*"); Review Comment: The failure on macOS comes from this. How the hell did it work beforehand still a mystery, but we need the minifi-python-lib-loader on macOS aswell. Cant put suggestions here (because your PR didnt change this) but instead of `ifdef __linux__` we should use `ifndef WIN32` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
